Stream: git-wasmtime

Topic: wasmtime / PR #5015 Tidy up the WASI `ErrorKind` enum.

Wasmtime GitHub notifications bot (Oct 04 2022 at 23:47):

sunfishcode opened PR #5015 from sunfishcode/error-kind to main:

ErrorKind is an internal enum used in wasi-libc to represent WASI errors that aren't precisely represened by std::io::ErrorKind errors. Add a descriptive comment, and remove some codes that are no longer needed:

• Remove NotCapable, which is no longer used.
• Remove WouldBlk, Exist, Noent, and Inval, which have one-to-one correspondences with codes in std::io::ErrorKind.

This will simplify the error handling in #4947 and #4967, as it means the code will no longer have to check for two different forms of these errors.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 05 2022 at 01:13):

sunfishcode updated PR #5015 from sunfishcode/error-kind to main.

Wasmtime GitHub notifications bot (Oct 05 2022 at 14:40):

alexcrichton merged PR #5015.

Wasmtime GitHub notifications bot (Oct 05 2022 at 14:41):

alexcrichton submitted PR review.

Last updated: Dec 23 2024 at 12:05 UTC