Stream: git-wasmtime

Topic: wasmtime / PR #5012 ISLE: More consistent use of `add_ins...

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:10):

elliottt opened PR #5012 from trevor/isle-ir-small-refactor to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:11):

elliottt edited PR #5012 from trevor/isle-ir-small-refactor to main:

Use the InstId returned by add_inst rather than creating it eagerly, when possible.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:15):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:38):

elliottt updated PR #5012 from trevor/isle-ir-small-refactor to main.

Wasmtime GitHub notifications bot (Oct 04 2022 at 22:59):

elliottt has marked PR #5012 as ready for review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 22:59):

elliottt merged PR #5012.

Last updated: Dec 23 2024 at 12:05 UTC