Stream: git-wasmtime

Topic: wasmtime / PR #5011 ISLE: Enable the overlap checker

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:23):

elliottt opened PR #5011 from trevor/enable-overlap-checking to main:

This PR turns the overlap checker on by default, requiring the use of priorities to resolve overlap between rules.

Additionally, I removed the overlap_errors pragma leaving the rest of the pragma parsing framework in place, and resolved overlaps in the isle tests.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:25):

elliottt updated PR #5011 from trevor/enable-overlap-checking to main.

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:29):

elliottt updated PR #5011 from trevor/enable-overlap-checking to main.

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:32):

cfallin created PR review comment:

... ah, and I see you have exactly that comment here :-) (Mentioning this in both places is still good, I think.)

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 20:32):

cfallin created PR review comment:

Can we put a comment here stating that currently no pragmas are defined (but the infrastructure remains from past pragmas and we are choosing to retain it to easily support future ones)? Otherwise this might look a bit odd to a new reader with no context.

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:06):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:06):

elliottt created PR review comment:

I'll copy this one over to the enum definition as well, thanks for catching that!

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:06):

elliottt updated PR #5011 from trevor/enable-overlap-checking to main.

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:27):

elliottt has enabled auto merge for PR #5011.

Wasmtime GitHub notifications bot (Oct 04 2022 at 21:56):

elliottt merged PR #5011.

Last updated: Dec 23 2024 at 12:05 UTC