Stream: git-wasmtime

Topic: wasmtime / PR #5002 Resolve overlap in the s390x backend

Wasmtime GitHub notifications bot (Oct 03 2022 at 21:37):

elliottt opened PR #5002 from trevor/resolve-s390x-overlap to main:

Resolve overlap in the s390x backend by adding rule priorities to disambiguate rule order.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 03 2022 at 21:38):

elliottt created PR review comment:

For this whole group, removing the use of if-let resolved the priority naturally.

Wasmtime GitHub notifications bot (Oct 03 2022 at 21:38):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 03 2022 at 21:42):

elliottt edited PR review comment.

Wasmtime GitHub notifications bot (Oct 03 2022 at 21:48):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2022 at 00:06):

elliottt merged PR #5002.

Last updated: Oct 23 2024 at 20:03 UTC