Stream: git-wasmtime

Topic: wasmtime / PR #5000 Consolidate module definition in `was...

Wasmtime GitHub notifications bot (Oct 03 2022 at 15:03):

alexcrichton opened PR #5000 from small-refactor to main:

Minor thing I noticed from #4990 but I stylistically prefer to keep the mod foo; definitions canonicalized to one location to emphasize how multiple targets can use the same definition.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 03 2022 at 15:49):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 03 2022 at 16:04):

alexcrichton merged PR #5000.

Last updated: Dec 23 2024 at 12:05 UTC