Stream: git-wasmtime

Topic: wasmtime / PR #4990 Initial work to build for Windows ARM64

Wasmtime GitHub notifications bot (Oct 01 2022 at 06:00):

Berrysoft opened PR #4990 from dev/winarm64 to main:

This is a PR to build wasmtime to Windows ARM64. According to @kpreisser on #4435 , it should work without traps.

Check list

• [x] This has been discussed in issue #4435

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Oct 01 2022 at 06:01):

Berrysoft updated PR #4990 from dev/winarm64 to main.

Wasmtime GitHub notifications bot (Oct 01 2022 at 06:05):

Berrysoft updated PR #4990 from dev/winarm64 to main.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:19):

cfallin created PR review comment:

Can we add a note here, with a link to the open issue, noting that Wasmtime is known to have issues on this platform (trap handling) and this is why it doesn't have a build with artifacts?

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:47):

Berrysoft edited PR #4990 from dev/winarm64 to main:

This is a PR to build wasmtime to Windows ARM64. According to @kpreisser on #4435 , it should work without traps.

Fixes #4435

Check list

• [x] This has been discussed in issue #4435

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:52):

Berrysoft updated PR #4990 from dev/winarm64 to main.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:53):

Berrysoft submitted PR review.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:53):

Berrysoft created PR review comment:

OK. I've opened a new issue to track the trap handling on Windows ARM64, and added the link.

Wasmtime GitHub notifications bot (Oct 03 2022 at 02:45):

cfallin created PR review comment:

Thanks!

Wasmtime GitHub notifications bot (Oct 03 2022 at 02:45):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 03 2022 at 02:45):

cfallin merged PR #4990.

Last updated: Nov 22 2024 at 17:03 UTC