Stream: git-wasmtime

Topic: wasmtime / PR #4987 Fall back to alternative membarrier c...

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:16):

cfallin opened PR #4987 from aarch64-membarrier-cmd-shared to main:

This is an attempt to fix #4972 by adding a fallback syscall that older kernels should support. The fallback is invoked only if the more specific membarrier fails.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:16):

cfallin requested akirilov-arm for a review on PR #4987.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:29):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:29):

bjorn3 created PR review comment:

RegisterPrivateExpeditedSyncCore registers intent to use PrivateExpeditedSyncCore later on in the publish method. Global should be used in publish and doesn't have an associated register command.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:37):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:37):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:37):

akirilov-arm created PR review comment:

This change should be applied to line 171 instead, and I think that here you can just use unwrap_or_default().

Since the EXPEDITED commands have additional overhead (according to the documentation), the process must opt in explicitly to use them via the corresponding REGISTER command (e.g. MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE); the call here is precisely that registration.

BTW in hindsight when I implemented this initially, adding this call here was probably not the best idea because the registration should happen only once for the whole lifetime of the process (instead of whenever a CodeMemory object is created, though subsequent registrations are harmless); perhaps the moment of the Engine creation is a better time? Of course, that assumes that no one is going to use a CodeMemory object without creating an Engine first.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:38):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2022 at 17:38):

akirilov-arm created PR review comment:

Ninja'd by @bjorn3 :smiley:.

Wasmtime GitHub notifications bot (Oct 03 2022 at 14:01):

akirilov-arm edited PR review comment.

Wasmtime GitHub notifications bot (Oct 04 2022 at 18:47):

cfallin closed without merge PR #4987.

Last updated: Nov 22 2024 at 16:03 UTC