Stream: git-wasmtime

Topic: wasmtime / PR #4983 ISLE: Always default the priority to 0

Wasmtime GitHub notifications bot (Sep 29 2022 at 20:57):

elliottt opened PR #4983 from trevor/no-optional-priority to main:

Make the priority field of the sema::Rule struct an i64 instead of an Option<i64>. As this value was always defaulted to 0 when used, this change removes a source of footguns when comparing priority values of different rules.

Additionally, fix a hidden overlap error in the x64 backend, where rules with no priority were seen to be written at a different priority level from those at priority 0.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 29 2022 at 20:58):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 29 2022 at 22:32):

elliottt merged PR #4983.

Last updated: Dec 23 2024 at 12:05 UTC