Stream: git-wasmtime

Topic: wasmtime / PR #4982 ISLE: Resolve overlap in the riscv64 ...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 19:48):

elliottt opened PR #4982 from trevor/resolve-riscv64-overlap to main:

Resolve overlap in the RiscV64 backend by adding priorities to rules. Additionally, one test updated as a result of this work, as a peephole optimization for addition with immediates fires now.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):

cfallin created PR review comment:

likewise here -- pre-existing but would you mind doing a search for [A-Za-z0-9]( and )[A-Za-z0-9] and fixing spaces around paren-forms?

(happy to do this in a separate PR if you'd rather get this in as-is but if it's easy...)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):

cfallin created PR review comment:

pre-existing but can we fix the formatting here while we're here (space after $true) and twice below?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 20:51):

elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 21:19):

elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2022 at 23:03):

elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2022 at 00:22):

elliottt merged PR #4982.


Last updated: Dec 23 2024 at 12:05 UTC