Wasmtime GitHub notifications bot (Sep 29 2022 at 19:48): Wasmtime GitHub notifications bot (Sep 29 2022 at 19:48):elliottt opened PR #4982 from trevor/resolve-riscv64-overlap to main:
Resolve overlap in the RiscV64 backend by adding priorities to rules. Additionally, one test updated as a result of this work, as a peephole optimization for addition with immediates fires now.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):cfallin created PR review comment:
likewise here -- pre-existing but would you mind doing a search for
[A-Za-z0-9](and)[A-Za-z0-9]and fixing spaces around paren-forms?(happy to do this in a separate PR if you'd rather get this in as-is but if it's easy...)
Wasmtime GitHub notifications bot (Sep 29 2022 at 19:56):cfallin created PR review comment:
pre-existing but can we fix the formatting here while we're here (space after
$true) and twice below?
Wasmtime GitHub notifications bot (Sep 29 2022 at 20:51):elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.
Wasmtime GitHub notifications bot (Sep 29 2022 at 21:19):elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.
Wasmtime GitHub notifications bot (Sep 29 2022 at 23:03):elliottt updated PR #4982 from trevor/resolve-riscv64-overlap to main.
Wasmtime GitHub notifications bot (Sep 30 2022 at 00:22):elliottt merged PR #4982.
Last updated: Nov 22 2024 at 16:03 UTC