Wasmtime GitHub notifications bot (Sep 28 2022 at 22:20): Wasmtime GitHub notifications bot (Sep 28 2022 at 22:20):elliottt opened PR #4976 from trevor/stable-overlap-error-output to main:
We were finding rules with the most overlap errors by traversing the hash map, but weren't doing anything to prevent the unstable order of the hash map elements from affecting the error output order. This PR includes the rule id when looking for rules that have the largest number of overlaps, to break ties predictably.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 28 2022 at 22:22):elliottt edited PR #4976 from trevor/stable-overlap-error-output to main:
We were finding rules with the most overlap errors by traversing a hash map, but weren't doing anything to prevent the unstable order of the hash map elements from affecting the error output order. This PR includes the rule id when looking for rules that have the largest number of overlaps, to break ties predictably.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 28 2022 at 23:59):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Sep 29 2022 at 00:23):elliottt merged PR #4976.
Last updated: Dec 23 2024 at 12:05 UTC