Wasmtime GitHub notifications bot (Sep 28 2022 at 17:52): Wasmtime GitHub notifications bot (Sep 28 2022 at 17:52):elliottt opened PR #4975 from trevor/sort-overlap-errors to main:
Two small changes to error reporting that make resolving large numbers of overlap errors a bit easier:
- Always output the error count last
- Sort the overlap errors by the position of the first rule in the list, to make it easier to know when you've locally resolved overlap errors.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 28 2022 at 18:04):elliottt updated PR #4975 from trevor/sort-overlap-errors to main.
Wasmtime GitHub notifications bot (Sep 28 2022 at 18:05):elliottt edited PR #4975 from trevor/sort-overlap-errors to main:
A small quality of life improvement for the overlap checker: sorting the errors to keep related overlaps together.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 28 2022 at 18:07):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Sep 28 2022 at 20:23):elliottt merged PR #4975.
Last updated: Dec 23 2024 at 13:07 UTC