Stream: git-wasmtime

Topic: wasmtime / PR #4964 Increase the `sigaltstack` stack size

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:09):

alexcrichton requested fitzgen for a review on PR #4964.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:09):

alexcrichton opened PR #4964 from increase-stack-size to main:

This commit updates the MIN_STACK_SIZE constant for Unix platforms when allocating a sigaltstack from 16k to 64k. The signal handler captures a wasm Backtrace which involves memory allocations and it was recently discovered that, at least in debug mode, jemalloc can take up to 16k of stack space for an allocation. To allow running the sigaltstack size is increased here.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:11):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:14):

alexcrichton has enabled auto merge for PR #4964.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:48):

alexcrichton merged PR #4964.

Last updated: Oct 23 2024 at 20:03 UTC