alexcrichton requested fitzgen for a review on PR #4964.
alexcrichton opened PR #4964 from increase-stack-size
to main
:
This commit updates the
MIN_STACK_SIZE
constant for Unix platforms when allocating a sigaltstack from 16k to 64k. The signal handler captures a wasmBacktrace
which involves memory allocations and it was recently discovered that, at least in debug mode, jemalloc can take up to 16k of stack space for an allocation. To allow running the sigaltstack size is increased here.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen submitted PR review.
alexcrichton has enabled auto merge for PR #4964.
alexcrichton merged PR #4964.
Last updated: Dec 23 2024 at 13:07 UTC