Stream: git-wasmtime

Topic: wasmtime / PR #4963 Remove `handling_trap` variable

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:04):

alexcrichton opened PR #4963 from minor-cleanup to main:

This historically was used to guard against recursive faults but later refactorings have made this variable somewhat obsolete. The code that it still protects is not the "meat" of trap handling. Instead the jmp_buf_if_trap is changed to be more like "take" so once a "take" succeeds it won't be able to recursively call any more "meat".

Overall this shouldn't affect anything, it's just a small internal cleanup.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:09):

alexcrichton requested fitzgen for a review on PR #4963.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:11):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:14):

alexcrichton has enabled auto merge for PR #4963.

Wasmtime GitHub notifications bot (Sep 26 2022 at 22:41):

alexcrichton merged PR #4963.

Last updated: Nov 22 2024 at 16:03 UTC