Stream: git-wasmtime

Topic: wasmtime / PR #4956 Fix wasmtime-bench-api build

Wasmtime GitHub notifications bot (Sep 25 2022 at 07:22):

jameysharp requested abrown for a review on PR #4956.

Wasmtime GitHub notifications bot (Sep 25 2022 at 07:22):

jameysharp opened PR #4956 from fix-bench-api to main:

This fixes a compile-time error introduced in #4207. The ? operator doesn't work inside Option::map because it tries to return from the inner closure, not the outer function.

Apparently our CI doesn't build wasmtime-bench-api so it didn't catch this issue.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 26 2022 at 03:39):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2022 at 03:39):

abrown merged PR #4956.

Last updated: Oct 23 2024 at 20:03 UTC