Stream: git-wasmtime

Topic: wasmtime / PR #4942 Port flag-based ops to ISLE (AArch64)

Wasmtime GitHub notifications bot (Sep 22 2022 at 10:04):

dheaton-arm opened PR #4942 from isle-flags to main:

Ported the existing implementations of the following opcodes for AArch64 to ISLE:

• Trueif
• Trueff
• Trapif
• Trapff
• Select
• Selectif
• SelectifSpectreGuard

Also fixed the implementation of true{if,ff} for the interpreter.

Copyright (c) 2022 Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 22 2022 at 10:36):

dheaton-arm updated PR #4942 from isle-flags to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 22:44):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2022 at 22:44):

cfallin created PR review comment:

Wow, I'm surprised the test was missing this before -- that was a clear miscompilation that I guess we never saw only because we always used the result of iadd_ifcout directly as well. In any case, this PR fixes the issue!

Wasmtime GitHub notifications bot (Sep 22 2022 at 22:44):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2022 at 22:44):

cfallin merged PR #4942.

Last updated: Dec 23 2024 at 12:05 UTC