Stream: git-wasmtime

Topic: wasmtime / PR #4905 Leverage Cargo's workspace inheritanc...

Wasmtime GitHub notifications bot (Sep 13 2022 at 15:59):

alexcrichton opened PR #4905 from workspace-inheritance to main:

This commit is an attempt to reduce the complexity of the Cargo
manifests in this repository with Cargo's workspace-inheritance feature
becoming stable in Rust 1.64.0. This feature allows specifying fields in
the root workspace Cargo.toml which are then reused throughout the
workspace. For example this PR shares definitions such as:

• All of the Wasmtime-family of crates now use version.workspace = true to have a single location which defines the version number.

• All crates use edition.workspace = true to have one default edition
  for the entire workspace.

• Common dependencies are listed in [workspace.dependencies] to avoid
  typing the same version number in a lot of different places (e.g. the
  wasmparser = "0.89.0" is now in just one spot.

Currently the workspace-inheritance feature doesn't allow having two
different versions to inherit, so all of the Cranelift-family of crates
still manually specify their version. The inter-crate dependencies,
however, are shared amongst the root workspace.

This feature can be seen as a method of "preprocessing" of sorts for
Cargo manifests. This will help us develop Wasmtime but shouldn't have
any actual impact on the published artifacts -- everything's dependency
lists are still the same.

Wasmtime GitHub notifications bot (Sep 13 2022 at 16:10):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2022 at 16:10):

bjorn3 created PR review comment:

This doesn't break using cranelift as path dependency from a different workspace, right?

Wasmtime GitHub notifications bot (Sep 13 2022 at 16:11):

bjorn3 created PR review comment:

Maybe use the cranelift-codegen.workspace = true shorthand?

Wasmtime GitHub notifications bot (Sep 13 2022 at 16:11):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2022 at 16:37):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 13 2022 at 17:18):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 13 2022 at 17:20):

alexcrichton created PR review comment:

I don't believe so, no

Wasmtime GitHub notifications bot (Sep 13 2022 at 17:20):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2022 at 17:21):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2022 at 17:21):

alexcrichton created PR review comment:

Personally I prefer the current form as it's easier to edit in optional = true and such and looks more similar to other dependencies. I think this is a matter of taste ultimately though.

Wasmtime GitHub notifications bot (Sep 13 2022 at 18:10):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 13 2022 at 18:29):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 14:33):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 14:35):

alexcrichton has marked PR #4905 as ready for review.

Wasmtime GitHub notifications bot (Sep 22 2022 at 14:56):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 15:20):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 17:45):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 18:23):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 22 2022 at 18:59):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 23 2022 at 22:10):

alexcrichton requested pchickey for a review on PR #4905.

Wasmtime GitHub notifications bot (Sep 26 2022 at 14:28):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 26 2022 at 15:10):

alexcrichton updated PR #4905 from workspace-inheritance to main.

Wasmtime GitHub notifications bot (Sep 26 2022 at 16:14):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2022 at 16:30):

alexcrichton merged PR #4905.

Last updated: Nov 22 2024 at 16:03 UTC