Stream: git-wasmtime

Topic: wasmtime / PR #4898 Port `icmp` to ISLE (AArch64)

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:34):

dheaton-arm opened PR #4898 from isle-icmp to main:

Ported the existing implementation of icmp (and, by extension, the lower_icmp function) to ISLE for AArch64.

Copyright (c) 2022 Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 12 2022 at 19:25):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2022 at 19:25):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2022 at 19:25):

cfallin created PR review comment:

This definitely works but it seems like we might be able to be slightly more descriptive and precise with the types here: ccmp both consumes and produces flags. Maybe we could:

• Define a new ProducesFlags enum arm that holds two instructions in sequence;
• Define a ccmp helper that takes an existing ProducesFlags and returns a ProducesFlags, gluing the ccmp onto the end of the existing producer as an "update" to the flags. (It's OK if we only handle the two-instruction case here for now; we can extend the enum later if necessary)

Thoughts?

Wasmtime GitHub notifications bot (Sep 13 2022 at 11:33):

dheaton-arm updated PR #4898 from isle-icmp to main.

Wasmtime GitHub notifications bot (Sep 13 2022 at 15:56):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2022 at 15:56):

cfallin merged PR #4898.

Last updated: Dec 23 2024 at 12:05 UTC