Wasmtime GitHub notifications bot (Sep 08 2022 at 18:16): Wasmtime GitHub notifications bot (Sep 08 2022 at 18:16):elliottt opened PR #4888 from trevor/remove-function-alignment to main:
Removes the
function_alignmentfield from ObjectBuilder and ObjectModule. Alignment information is now provided either by theModuletrait for minimum function alignment requirements, or onFunctionInfofor fucntion specific alignment requirements.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 08 2022 at 18:16):elliottt has marked PR #4888 as ready for review.
Wasmtime GitHub notifications bot (Sep 08 2022 at 18:46):elliottt requested jameysharp for a review on PR #4888.
Wasmtime GitHub notifications bot (Sep 08 2022 at 18:47):elliottt edited PR #4888 from trevor/remove-function-alignment to main:
Removes the
function_alignmentfield from ObjectBuilder and ObjectModule. Alignment information is now provided either by theModuletrait for minimum function alignment requirements, or onFunctionInfofor fucntion specific alignment requirements.cc @bjorn3
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 08 2022 at 18:54):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Sep 08 2022 at 19:39):elliottt updated PR #4888 from trevor/remove-function-alignment to main.
Wasmtime GitHub notifications bot (Sep 08 2022 at 22:54):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Sep 09 2022 at 16:30):elliottt updated PR #4888 from trevor/remove-function-alignment to main.
Wasmtime GitHub notifications bot (Sep 09 2022 at 20:42):elliottt updated PR #4888 from trevor/remove-function-alignment to main.
Wasmtime GitHub notifications bot (Sep 12 2022 at 17:15):elliottt merged PR #4888.
Last updated: Dec 23 2024 at 12:05 UTC