Stream: git-wasmtime

Topic: wasmtime / PR #4884 Interpreter: Implement floating point...

Wasmtime GitHub notifications bot (Sep 08 2022 at 10:16):

dheaton-arm opened PR #4884 from interpret-fcvt to main:

Implemented the following opcodes for the interpreter:

• FcvtToUint
• FcvtToSint
• FcvtToUintSat
• FcvtToSintSat
• FcvtFromUint
• FcvtFromSint
• FcvtLowFromSint
• FvpromoteLow
• Fvdemote

Copyright (c) 2022 Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 created PR review comment:

                if x.is_nan()? {

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 created PR review comment:

            if arg(0)?.is_nan()? {

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 created PR review comment:

            let is_signed = inst.opcode() == Opcode::FcvtToSint;
            let (min, max) = ctrl_ty.bounds(is_signed);

Minor nit, but it took me a while to understand what was going on

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 created PR review comment:

                    let is_signed = inst.opcode() == Opcode::FcvtToSintSat;
                    let (min, max) = ctrl_ty.bounds(is_signed);

Similar to above, a small nit.

Wasmtime GitHub notifications bot (Sep 12 2022 at 10:49):

afonso360 created PR review comment:

I think we should be able to remove the simd and sse flags since these aren't simd tests right?

Wasmtime GitHub notifications bot (Sep 12 2022 at 12:06):

dheaton-arm updated PR #4884 from interpret-fcvt to main.

Wasmtime GitHub notifications bot (Sep 12 2022 at 12:13):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2022 at 12:17):

dheaton-arm updated PR #4884 from interpret-fcvt to main.

Wasmtime GitHub notifications bot (Sep 20 2022 at 18:10):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 20 2022 at 18:11):

jameysharp merged PR #4884.

Last updated: Dec 23 2024 at 12:05 UTC