Wasmtime GitHub notifications bot (Sep 06 2022 at 23:41): Wasmtime GitHub notifications bot (Sep 06 2022 at 23:41):jameysharp requested elliottt for a review on PR #4879.
Wasmtime GitHub notifications bot (Sep 06 2022 at 23:41):jameysharp opened PR #4879 from no-intcc-overflow to main:
Neither Wasmtime nor cg-clif use these flags under any circumstances. From discussion on #3060 I see it's long been unclear what purpose these flags served.
Fixes #3060, fixes #4406, and fixes #4875... by deleting all the code that could have been buggy.
This changes the cranelift-fuzzgen input format by removing some IntCC options, so I've gone ahead and enabled I128 icmp tests at the same time. Since only the of/nof cases were failing before, I expect these to work.
cc: @afonso360
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 06 2022 at 23:41):jameysharp requested fitzgen for a review on PR #4879.
Wasmtime GitHub notifications bot (Sep 07 2022 at 00:01):jameysharp updated PR #4879 from no-intcc-overflow to main.
Wasmtime GitHub notifications bot (Sep 07 2022 at 00:28):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2022 at 15:03):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2022 at 15:38):jameysharp merged PR #4879.
Last updated: Nov 22 2024 at 17:03 UTC