Wasmtime GitHub notifications bot (Sep 06 2022 at 23:11): Wasmtime GitHub notifications bot (Sep 06 2022 at 23:11):elliottt opened PR #4878 from trevor/rework-x64-isle-flags to main:
Using fallible extractors that produce no values for flag checks means
that it's not possible to pattern match cases where those flags are
false. This change reworks the existing flag-checking extractors to be
infallible, returning the flag's boolean value from the context instead.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 06 2022 at 23:11):elliottt edited PR #4878 from trevor/rework-x64-isle-flags to main:
Using fallible extractors that produce no values for flag checks means that it's not possible to pattern match cases where those flags are false. This change reworks the existing flag-checking extractors to be infallible, returning the flag's boolean value from the context instead.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 06 2022 at 23:13):elliottt edited PR #4878 from trevor/rework-x64-isle-flags to main:
Using fallible extractors that produce no values for flag checks means that it's not possible to pattern match cases where those flags are false. This change reworks the existing flag-checking extractors to be infallible, returning the flag's boolean value from the context instead.
I think this change should allow rule priorities to be removed in many cases, but I'd rather leave that for a follow-up PR.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 06 2022 at 23:13):elliottt has marked PR #4878 as ready for review.
Wasmtime GitHub notifications bot (Sep 07 2022 at 15:12):abrown submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2022 at 20:49):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2022 at 20:49):fitzgen merged PR #4878.
Last updated: Dec 23 2024 at 12:05 UTC