Stream: git-wasmtime

Topic: wasmtime / PR #4877 Don't reverse icmp nof/of

Wasmtime GitHub notifications bot (Sep 06 2022 at 22:08):

elliottt opened PR #4877 from trevor/fix-4875 to main:

The implementation of IntCC::reverse considered the reverse of
NotOverflow to be NotOverflow, but this isn't correct as the comparison does
not commute. The solution here was to change the reverse function of the
CondCode trait to return an Option, and then use the function as a fallible
extractor in the isle rule that floats constants right in comparisons.

Fixes #4875
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 06 2022 at 22:10):

elliottt has marked PR #4877 as ready for review.

Wasmtime GitHub notifications bot (Sep 06 2022 at 22:10):

elliottt edited PR #4877 from trevor/fix-4875 to main:

The implementation of IntCC::reverse considered the reverse of NotOverflow to be NotOverflow, but this isn't correct as the comparison does not commute. The solution here was to change the reverse function of the CondCode trait to return an Option, and then use the function as a fallible extractor in the isle rule that floats constants right in comparisons.

Fixes #4875
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 06 2022 at 22:18):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 06 2022 at 22:56):

elliottt closed without merge PR #4877.

Last updated: Dec 06 2025 at 06:05 UTC