Stream: git-wasmtime

Topic: wasmtime / PR #4876 x64: remove `Inst::XmmLoadConst`

Wasmtime GitHub notifications bot (Sep 06 2022 at 18:05):

abrown edited PR #4876 from remove-load-xmm-const to main:

This is a cherry-pick of a long-ago commit, 2d46637. The original
message reads:

Now that SyntheticAmode can refer to constants, there is no longer a
need for a separate instruction format--standard load instructions will
work.

Since then, the transition to ISLE and the use of XmmLoadConst in many
more places makes this change a larger diff than the original. The basic
idea is the same, though: the extra indirection of Inst::XMmLoadConst
is removed and replaced by a direct use of VCodeConstant as a
SyntheticAmode. This has no effect on codegen, but the CLIF output is
now clearer in that the actual instruction is displayed (e.g., movdqu)
instead of a made-up instruction (load_const).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 06 2022 at 18:05):

abrown updated PR #4876 from remove-load-xmm-const to main.

Wasmtime GitHub notifications bot (Sep 06 2022 at 19:18):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 07 2022 at 15:13):

abrown requested elliottt for a review on PR #4876.

Wasmtime GitHub notifications bot (Sep 07 2022 at 19:42):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 07 2022 at 19:52):

abrown merged PR #4876.

Last updated: Dec 23 2024 at 12:05 UTC