jameysharp requested fitzgen for a review on PR #4860.
jameysharp opened PR #4860 from fix-4857
to main
:
This fixes #4857 by partially reverting #4849.
It turns out that
Ieee32
andIeee64
need bitwise equality semantics so they can be used as hash-table keys.Moving the IEEE754 semantics up a layer to
DataValue
makes sense in conjunction with #4855, where we introduced aDataValue::bitwise_eq
alternative implementation of equality for those cases where users ofDataValue
still want the bitwise equality semantics.cc: @afonso360
jameysharp requested alexcrichton for a review on PR #4860.
jameysharp requested cfallin for a review on PR #4860.
jameysharp updated PR #4860 from fix-4857
to main
.
cfallin submitted PR review.
jameysharp updated PR #4860 from fix-4857
to main
.
jameysharp has enabled auto merge for PR #4860.
jameysharp merged PR #4860.
Last updated: Dec 23 2024 at 12:05 UTC