Stream: git-wasmtime

Topic: wasmtime / PR #4860 Make DataValue, not Ieee32/64, respec...

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:15):

jameysharp requested fitzgen for a review on PR #4860.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:15):

jameysharp opened PR #4860 from fix-4857 to main:

This fixes #4857 by partially reverting #4849.

It turns out that Ieee32 and Ieee64 need bitwise equality semantics so they can be used as hash-table keys.

Moving the IEEE754 semantics up a layer to DataValue makes sense in conjunction with #4855, where we introduced a DataValue::bitwise_eq alternative implementation of equality for those cases where users of DataValue still want the bitwise equality semantics.

cc: @afonso360

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:15):

jameysharp requested alexcrichton for a review on PR #4860.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:15):

jameysharp requested cfallin for a review on PR #4860.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:29):

jameysharp updated PR #4860 from fix-4857 to main.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:43):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:56):

jameysharp updated PR #4860 from fix-4857 to main.

Wasmtime GitHub notifications bot (Sep 02 2022 at 23:56):

jameysharp has enabled auto merge for PR #4860.

Wasmtime GitHub notifications bot (Sep 03 2022 at 00:26):

jameysharp merged PR #4860.

Last updated: Nov 22 2024 at 17:03 UTC