Stream: git-wasmtime

Topic: wasmtime / PR #4859 Throw out fewer fuzz inputs with diff...

Wasmtime GitHub notifications bot (Sep 02 2022 at 22:12):

alexcrichton opened PR #4859 from improve-differential to main:

Prior to this commit the differential fuzzer would generate a module and
then select an engine to execute the module against Wasmtime. This
meant, however, that the candidate list of engines were filtered against
the configuration used to generate the module to ensure that the
selected engine could run the generated module.

This commit inverts this logic and instead selects an engine first,
allowing the engine to then tweak the module configuration to ensure
that the generated module is compatible with the engine selected. This
means that fewer fuzz inputs are discarded because every fuzz input will
result in an engine being executed.

Internally the engine constructors have all been updated to update the
configuration to work instead of filtering the configuration. Some other
fixes were applied for the spec interpreter as well to work around #4852

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 02 2022 at 22:12):

alexcrichton requested fitzgen for a review on PR #4859.

Wasmtime GitHub notifications bot (Sep 02 2022 at 22:12):

alexcrichton requested abrown for a review on PR #4859.

Wasmtime GitHub notifications bot (Sep 06 2022 at 14:03):

alexcrichton updated PR #4859 from improve-differential to main.

Wasmtime GitHub notifications bot (Sep 06 2022 at 16:50):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Sep 06 2022 at 17:41):

alexcrichton merged PR #4859.

Last updated: Oct 23 2024 at 20:03 UTC