afonso360 opened PR #4855 from fuzz-bit-cmp
to main
:
cc: 4849
cc: @jameysharp
jameysharp submitted PR review.
jameysharp created PR review comment:
For future reference, it's possible to write this more tersely.
Iterator::zip
will implicitly callinto_iter()
on whatever you pass to it, so you can just use.zip(expected)
. And the implementation ofinto_iter()
on&Vec
is the same as callingiter()
(they both return references to the elements of the vector) so you can use the shorter name. When I was playing with this locally I found that those two changes meant this part of the expression would fit on one line withcargo fmt
s defaults. :grin:This is not remotely important, so I'm merging without that change and please don't bother writing another PR for it. This version is just fine as-is. But I thought I'd note the alternative.
jameysharp submitted PR review.
jameysharp has enabled auto merge for PR #4855.
jameysharp merged PR #4855.
Last updated: Dec 23 2024 at 12:05 UTC