Stream: git-wasmtime

Topic: wasmtime / PR #4855 cranelift: Bitwise compare fuzzgen re...

Wasmtime GitHub notifications bot (Sep 02 2022 at 18:51):

afonso360 opened PR #4855 from fuzz-bit-cmp to main:

cc: 4849
cc: @jameysharp

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:01):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:01):

jameysharp created PR review comment:

For future reference, it's possible to write this more tersely. Iterator::zip will implicitly call into_iter() on whatever you pass to it, so you can just use .zip(expected). And the implementation of into_iter() on &Vec is the same as calling iter() (they both return references to the elements of the vector) so you can use the shorter name. When I was playing with this locally I found that those two changes meant this part of the expression would fit on one line with cargo fmts defaults. :grin:

This is not remotely important, so I'm merging without that change and please don't bother writing another PR for it. This version is just fine as-is. But I thought I'd note the alternative.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:01):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:01):

jameysharp has enabled auto merge for PR #4855.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:34):

jameysharp merged PR #4855.

Last updated: Oct 23 2024 at 20:03 UTC