Wasmtime GitHub notifications bot (Sep 02 2022 at 15:14): Wasmtime GitHub notifications bot (Sep 02 2022 at 15:14):alexcrichton opened PR #4853 from list-is-expensive to main:
I noticed an oss-fuzz-based timeout that was reported for the
component_apifuzzer where the adapter module generated takes 1.5
seconds to compile the singular function in release mode (no fuzzing
enabled). The test case in question was a deeply recursive
list-of-list-of-etc and only one function was generated instead of
multiple. I updated the cost of strings/lists to cost more in the
approximate cost calculation which now forces the one giant function to
get split up and the large function is now split up into multiple
smaller function that take milliseconds to compile.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 02 2022 at 16:52):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Sep 02 2022 at 17:43):alexcrichton has enabled auto merge for PR #4853.
Wasmtime GitHub notifications bot (Sep 02 2022 at 18:11):alexcrichton merged PR #4853.
Last updated: Nov 22 2024 at 17:03 UTC