Stream: git-wasmtime

Topic: wasmtime / PR #4845 Various improvements to differential ...

Wasmtime GitHub notifications bot (Sep 02 2022 at 03:12):

alexcrichton opened PR #4845 from improve-differential-fuzzing to main:

I separated out a few commits below to the differential fuzzer which I was working on recently. The main changes are:

• A start function is now allowed. Support was added to wasmi to run the start function.
• Fuzzing now can continue if no engines match the current test case. This is only applicable if ALLOWED_ENGINES is set.
• Unstable proposals like memory64 should be less likely to get generated, ideally improving the rate of usage of engines like v8 and wasmi.
• A bug related to stack overflow was fixed where if one engine stack overflows it may have inconsistent state with the other so the fuzz test case needs to be discarded from then on.

Wasmtime GitHub notifications bot (Sep 02 2022 at 03:12):

alexcrichton requested abrown for a review on PR #4845.

Wasmtime GitHub notifications bot (Sep 02 2022 at 14:03):

alexcrichton updated PR #4845 from improve-differential-fuzzing to main.

Wasmtime GitHub notifications bot (Sep 02 2022 at 16:43):

fitzgen created PR review comment:

Instead of bailing out when an engine doesn't support a config, can we have a pre-pass where the engine is given mutable access to the config to turn off anything that it doesn't support? This just seems like better use of fuzzing time than rejecting iterations and bailing out.

Wasmtime GitHub notifications bot (Sep 02 2022 at 16:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 16:43):

fitzgen created PR review comment:

Slightly surprised we would ever have a case where we can't run the test case in Wasmtime. What is even the point at that time?

Wasmtime GitHub notifications bot (Sep 02 2022 at 16:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 16:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 18:43):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 18:43):

jameysharp created PR review comment:

I think the issue this is addressing is if testing Wasmtime against Wasmtime has been disabled using the ALLOWED_ENGINES environment variable.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:15):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:15):

alexcrichton created PR review comment:

Yeah I've come around to feeling this way as well, I'll work on refactoring to enable this

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:16):

alexcrichton created PR review comment:

Ah yeah this is only applicable when you're doing something like ALLOWED_ENGINES=wasmi locally where I was trying to only differentially-execute against wasmi

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:16):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2022 at 19:16):

alexcrichton merged PR #4845.

Last updated: Oct 23 2024 at 20:03 UTC