Stream: git-wasmtime

Topic: wasmtime / PR #4842 x64: fix CvtFloatToUintSeq: do not cl...

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin requested fitzgen for a review on PR #4842.

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin opened PR #4842 from fix-fuzzbug-4840 to main:

This slipped through the regalloc2 operand code update in #4811: the
CvtFloatToUintSeq pseudo-instruction actually clobbers its source. It
was marked as a "mod" operand in the original and I mistakenly
converted it to a "use" as I had not seen the actual clobber. The
instruction now takes an extra temp and makes a copy of src in the
appropriate place.

Fixes #4840.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin requested elliottt for a review on PR #4842.

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:58):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:05):

cfallin updated PR #4842 from fix-fuzzbug-4840 to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:06):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:06):

jameysharp created PR review comment:

This change looks like it was accidentally committed.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin updated PR #4842 from fix-fuzzbug-4840 to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin created PR review comment:

Urgh, yep, good catch, and thanks!

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2022 at 21:20):

cfallin has enabled auto merge for PR #4842.

Wasmtime GitHub notifications bot (Sep 01 2022 at 22:46):

cfallin merged PR #4842.

Last updated: Nov 22 2024 at 16:03 UTC