Stream: git-wasmtime

Topic: wasmtime / PR #4842 x64: fix CvtFloatToUintSeq: do not cl...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin requested fitzgen for a review on PR #4842.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin opened PR #4842 from fix-fuzzbug-4840 to main:

This slipped through the regalloc2 operand code update in #4811: the
CvtFloatToUintSeq pseudo-instruction actually clobbers its source. It
was marked as a "mod" operand in the original and I mistakenly
converted it to a "use" as I had not seen the actual clobber. The
instruction now takes an extra temp and makes a copy of src in the
appropriate place.

Fixes #4840.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 20:36):

cfallin requested elliottt for a review on PR #4842.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 20:58):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:05):

cfallin updated PR #4842 from fix-fuzzbug-4840 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:06):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:06):

jameysharp created PR review comment:

This change looks like it was accidentally committed.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin updated PR #4842 from fix-fuzzbug-4840 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin created PR review comment:

Urgh, yep, good catch, and thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:16):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 21:20):

cfallin has enabled auto merge for PR #4842.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2022 at 22:46):

cfallin merged PR #4842.


Last updated: Dec 23 2024 at 12:05 UTC