Stream: git-wasmtime

Topic: wasmtime / PR #4841 x64: improve tests for `heap_addr`

Wasmtime GitHub notifications bot (Sep 01 2022 at 17:50):

abrown requested cfallin for a review on PR #4841.

Wasmtime GitHub notifications bot (Sep 01 2022 at 17:50):

abrown opened PR #4841 from heap-addr-tests to main:

This change adds Cranelift compile tests for the various cases for
heap_addr. The idea behind this is to more clearly show what the
penalties are for dynamically- vs statically-allocated memory as well as
turning Spectre mitigations on and off.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 01 2022 at 17:59):

abrown updated PR #4841 from heap-addr-tests to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:56):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:59):

abrown has marked PR #4841 as ready for review.

Wasmtime GitHub notifications bot (Sep 01 2022 at 20:59):

abrown merged PR #4841.

Last updated: Oct 23 2024 at 20:03 UTC