Stream: git-wasmtime

Topic: wasmtime / PR #4823 Add MInst.XmmUnaryRmRImm to handle ro...

Wasmtime GitHub notifications bot (Aug 30 2022 at 17:13):

elliottt opened PR #4823 from trevor/add-xmm-unary-rm-r-imm to main:

Add a new pseudo-instruction, XmmUnaryRmRImm, to handle instructions like roundss that only use their first register argument for the instruction's result.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 30 2022 at 17:14):

elliottt has marked PR #4823 as ready for review.

Wasmtime GitHub notifications bot (Aug 30 2022 at 17:14):

elliottt requested cfallin for a review on PR #4823.

Wasmtime GitHub notifications bot (Aug 30 2022 at 17:17):

elliottt edited PR #4823 from trevor/add-xmm-unary-rm-r-imm to main:

Add a new pseudo-instruction, XmmUnaryRmRImm, to handle instructions like roundss that only use their first register argument for the instruction's result. This has the added benefit of allowing the isle wrappers for those instructions to take an XmmMem argument, allowing for more cases where loads may be merged.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 30 2022 at 18:33):

elliottt updated PR #4823 from trevor/add-xmm-unary-rm-r-imm to main.

Wasmtime GitHub notifications bot (Aug 31 2022 at 05:28):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2022 at 15:29):

elliottt merged PR #4823.

Last updated: Dec 23 2024 at 13:07 UTC