Stream: git-wasmtime

Topic: wasmtime / PR #4815 Fix lowering issue in x64 vany_true: ...

Wasmtime GitHub notifications bot (Aug 30 2022 at 03:44):

cfallin opened PR #4815 from fix-4807-fuzzbug to main:

The x64 lowring of vany_true both sinks mergeable loads and uses the
original register. This PR fixes the lowering to force the value into a
register first. Ideally we should solve the issue by catching this in
the ISLE type system, as described in #4745, but this resolves the issue
for now.

Fixes #4807.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 30 2022 at 03:44):

cfallin requested elliottt for a review on PR #4815.

Wasmtime GitHub notifications bot (Aug 30 2022 at 05:19):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 30 2022 at 05:22):

cfallin merged PR #4815.

Last updated: Dec 23 2024 at 12:05 UTC