Stream: git-wasmtime

Topic: wasmtime / PR #4813 [WIP]feat: add a knob for reset stack

Wasmtime GitHub notifications bot (Aug 31 2022 at 12:29):

Duslia edited PR #4813 from feat/knob_for_reset_stack to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->
This PR has been discussed in #4637. I add a knob for reset stack.

Wasmtime GitHub notifications bot (Aug 31 2022 at 12:52):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Aug 31 2022 at 12:54):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Aug 31 2022 at 13:02):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Aug 31 2022 at 15:04):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2022 at 15:04):

alexcrichton created PR review comment:

I think it's ok to drop this as it's always used by the snippet below

Wasmtime GitHub notifications bot (Aug 31 2022 at 15:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2022 at 15:05):

alexcrichton created PR review comment:

This last sentence will need an update since this PR is also changing the defaults.

Wasmtime GitHub notifications bot (Sep 01 2022 at 06:23):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 06:23):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 06:34):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 08:17):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 09:27):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Wasmtime GitHub notifications bot (Sep 01 2022 at 09:29):

Duslia updated PR #4813 from feat/knob_for_reset_stack to main.

Last updated: Oct 23 2024 at 20:03 UTC