Stream: git-wasmtime

Topic: wasmtime / PR #4809 x64: Lower nop in ISLE

Wasmtime GitHub notifications bot (Aug 29 2022 at 23:58):

elliottt opened PR #4809 from trevor/move-nop-to-isle to main:

Lower nop in ISLE in the x64 backend, and remove the final Ok(()) from the lower function to assert that all cases that fall through will panic.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 29 2022 at 23:59):

elliottt updated PR #4809 from trevor/move-nop-to-isle to main.

Wasmtime GitHub notifications bot (Aug 29 2022 at 23:59):

elliottt has marked PR #4809 as ready for review.

Wasmtime GitHub notifications bot (Aug 30 2022 at 00:03):

elliottt edited PR #4809 from trevor/move-nop-to-isle to main:

Lower nop in ISLE in the x64 backend, and remove the final Ok(()) from the lower function to assert that all cases that aren't handled in ISLE will panic.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 30 2022 at 01:00):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 30 2022 at 05:22):

elliottt updated PR #4809 from trevor/move-nop-to-isle to main.

Wasmtime GitHub notifications bot (Aug 30 2022 at 16:14):

elliottt merged PR #4809.

Last updated: Nov 22 2024 at 16:03 UTC