Stream: git-wasmtime

Topic: wasmtime / PR #4801 cranelift: Test calling across differ...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 11:13):

afonso360 opened PR #4801 from call-cc to main:

:wave: Hey,

This is a continuation of the TODO items in #4667 . It looks like #4667 accidentally already enables us to mix calling conventions so we don't need to do anything except remove an unused error.

This is an important feature for https://github.com/bytecodealliance/wasmtime/issues/4566 since we decided to mark big/little endian behaviour via calling convention, so this allows us to write runtests for that.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 23:24):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 23:55):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 23:55):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 23:55):

cfallin created PR review comment:

fast and system_v are actually the same in practice right now -- perhaps we could try system_v and windows_fastcall ?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2022 at 07:44):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2022 at 07:44):

afonso360 created PR review comment:

That might not work on aarch64 and s390x, but we can try one of the wasmtime ones.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2022 at 07:50):

afonso360 updated PR #4801 from call-cc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2022 at 22:16):

jameysharp merged PR #4801.

Last updated: Nov 22 2024 at 17:03 UTC