Stream: git-wasmtime

Topic: wasmtime / PR #4797 Disable funcref generation for fuzz t...

Wasmtime GitHub notifications bot (Aug 27 2022 at 00:19):

jameysharp opened PR #4797 from disable-funcrefs to main:

Don't merge until we're ready to invalidate all of our currently-open cranelift-fuzzgen fuzz-bugs.

Per @afonso360's suggestion on #4758, this makes cranelift-fuzzgen stop generating references to functions which don't exist. It also disables generating libcalls, which weren't that big of a problem, but it's fine to just not test them until we have those bits in better shape.

This fixes #4757, fixes #4758, and fixes new fuzzbugs that are probably coming after we merged #4667.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 27 2022 at 00:19):

jameysharp requested cfallin for a review on PR #4797.

Wasmtime GitHub notifications bot (Aug 27 2022 at 06:13):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Aug 29 2022 at 19:56):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 29 2022 at 21:30):

jameysharp has marked PR #4797 as ready for review.

Wasmtime GitHub notifications bot (Aug 29 2022 at 21:30):

jameysharp merged PR #4797.

Last updated: Nov 22 2024 at 16:03 UTC