Stream: git-wasmtime

Topic: wasmtime / PR #4794 Modifies fcvt_to_sint and fcvt_to_uni...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 22:54):

jlb6740 opened PR #4794 from fix-4693 to main:

This PR is in response to issue 4693. It modifies fcvt_to_sint and fcvt_to_unit clif instructions to make them scalar only so that the vector version is invalid and so that we don't panic in the back-end if those vector version of those cliff instructions are generated.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 22:54):

jlb6740 edited PR #4794 from fix-4693 to main:

This PR is in response to issue #4693. It modifies fcvt_to_sint and fcvt_to_unit clif instructions to make them scalar only so that the vector version is invalid and so that we don't panic in the back-end if those vector version of those cliff instructions are generated.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 22:55):

jlb6740 requested abrown for a review on PR #4794.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 22:55):

jlb6740 requested cfallin for a review on PR #4794.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 22:55):

jlb6740 requested elliottt for a review on PR #4794.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 23:43):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 01:29):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 01:29):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 01:29):

abrown created PR review comment:

        "FloatScalar",

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2022 at 19:50):

jlb6740 updated PR #4794 from fix-4693 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2022 at 20:00):

jlb6740 created PR review comment:

Oh .. about this. That was my instinct as well, but I didn't want to do sFloat because s in front is already used to designate signed. Such as sInt. I think FloatScalar is very clear. sFloat isn't.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2022 at 20:00):

jlb6740 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2022 at 20:01):

jlb6740 deleted PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2022 at 20:04):

jlb6740 updated PR #4794 from fix-4693 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 15:40):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 15:40):

abrown merged PR #4794.

Last updated: Dec 23 2024 at 12:05 UTC