Stream: git-wasmtime

Topic: wasmtime / PR #4788 AArch64: Migrate calls and returns to...

Wasmtime GitHub notifications bot (Aug 26 2022 at 00:10):

cfallin requested akirilov-arm for a review on PR #4788.

Wasmtime GitHub notifications bot (Aug 26 2022 at 00:10):

cfallin requested elliottt for a review on PR #4788.

Wasmtime GitHub notifications bot (Aug 26 2022 at 00:10):

cfallin opened PR #4788 from aarch64-isle-call-ret to main:

This borrows some machinery from x64 and makes it common. The order of setup for on-stack args is reversed now, but that seems OK if it means we can share more code!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:20):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:20):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:20):

elliottt created PR review comment:

Not at all blocking, but I wonder what a better name for this would be now that it's shared between multiple backends.

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:20):

elliottt created PR review comment:

What caused this change?

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:25):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:25):

cfallin created PR review comment:

The returns are going through a different path now, so the immediate handling is a little different; but this is still correct I think (movn x0, #0 generates all-ones, which for an i32 func is the same as u32::MAX in the return register).

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:26):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:26):

cfallin created PR review comment:

We can definitely think more about this -- it also felt a little strange to put it in prelude.isle to be honest; it seems more like we need a library of "common lowering helpers" that is separate from the language and ISLE-binding prelude proper. But, we can refine more in subsequent PRs!

Wasmtime GitHub notifications bot (Aug 26 2022 at 23:26):

cfallin merged PR #4788.

Last updated: Dec 23 2024 at 12:05 UTC