Stream: git-wasmtime

Topic: wasmtime / PR #4785 AArch64: port load and store operatio...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2022 at 20:46):

cfallin edited PR #4785 from aarch64-isle-loads to main:

This retains lower_amode in the handwritten code (@akirilov-arm
reports that there is an upcoming patch to port this), but tweaks it
slightly to take a Value rather than an Inst.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2022 at 23:52):

cfallin updated PR #4785 from aarch64-isle-loads to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 00:48):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 00:48):

elliottt created PR review comment:

Did you mean to remove the Sextend case?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 00:48):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:08):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:08):

cfallin created PR review comment:

Argh, no, I was playing with refactoring this a bit (splitting by uextend/sextend toplevel) and didn't revert completely. Thanks for catching!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:10):

cfallin updated PR #4785 from aarch64-isle-loads to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:10):

cfallin has enabled auto merge for PR #4785.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:10):

cfallin has disabled auto merge for PR #4785.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:28):

cfallin created PR review comment:

Also, now that I'm looking at this again, I had a momentary panic that we had another sign-extend bug (déjà-vu!); the reason that this isn't, for anyone watching, is that for narrower-than-32 extends we push the extended value (the output of the extend op) onto addends64, rather than the input to the extend. The 32-bit case is handled above specially with the extend incorporated into the amode if possible.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2022 at 02:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 20:01):

cfallin updated PR #4785 from aarch64-isle-loads to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 20:01):

cfallin requested elliottt for a review on PR #4785.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2022 at 20:36):

cfallin updated PR #4785 from aarch64-isle-loads to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2022 at 00:01):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2022 at 00:45):

cfallin merged PR #4785.

Last updated: Dec 23 2024 at 12:05 UTC