Stream: git-wasmtime

Topic: wasmtime / PR #4775 Update ISLE error message: unknown te...

Wasmtime GitHub notifications bot (Aug 24 2022 at 19:40):

cfallin requested elliottt for a review on PR #4775.

Wasmtime GitHub notifications bot (Aug 24 2022 at 19:40):

cfallin opened PR #4775 from isle-error-message to main:

This was likely a copy-paste from the ast::Pattern case, but here it
is checking a term name in ast::Expr and so should say "... in
expression", not "... in pattern".

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 24 2022 at 19:46):

jameysharp created PR review comment:

I suppose if bindings.vars.iter().any(|b| b.name == sym), then you could extend the error message to note that there is a variable by that name. That might have helped in the case that brought this mistake to your attention.

Wasmtime GitHub notifications bot (Aug 24 2022 at 19:46):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Aug 24 2022 at 20:20):

cfallin updated PR #4775 from isle-error-message to main.

Wasmtime GitHub notifications bot (Aug 24 2022 at 20:20):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 24 2022 at 20:20):

cfallin created PR review comment:

Great idea, thanks! Just added.

Wasmtime GitHub notifications bot (Aug 24 2022 at 21:21):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Aug 24 2022 at 21:23):

cfallin updated PR #4775 from isle-error-message to main.

Wasmtime GitHub notifications bot (Aug 24 2022 at 21:23):

cfallin has enabled auto merge for PR #4775.

Wasmtime GitHub notifications bot (Aug 24 2022 at 21:33):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 24 2022 at 22:07):

cfallin merged PR #4775.

Last updated: Dec 23 2024 at 13:07 UTC