Stream: git-wasmtime

Topic: wasmtime / PR #4774 [fuzz] Simplify macros used by single...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 18:21):

abrown opened PR #4774 from fuzz-single-inst to main:

This removes the multiple macros used previously to describe the
WebAssembly instruction signatures and replaces them with a single
one--inst!.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 18:21):

abrown requested jameysharp for a review on PR #4774.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):

jameysharp created PR review comment:

I don't off-hand see any reason why there has to be a minimum of one instruction argument. I'd think all the repetitions around $arguments_ty in both macro cases could use * instead of +. But given that all the current instructions do have at least one argument, obviously that's not a necessary change.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:35):

abrown updated PR #4774 from fuzz-single-inst to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:53):

abrown has enabled auto merge for PR #4774.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 20:10):

abrown merged PR #4774.


Last updated: Dec 23 2024 at 13:07 UTC