Wasmtime GitHub notifications bot (Aug 24 2022 at 18:21): Wasmtime GitHub notifications bot (Aug 24 2022 at 18:21):abrown opened PR #4774 from fuzz-single-inst to main:
This removes the multiple macros used previously to describe the
WebAssembly instruction signatures and replaces them with a single
one--inst!.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 24 2022 at 18:21):abrown requested jameysharp for a review on PR #4774.
Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Aug 24 2022 at 19:15):jameysharp created PR review comment:
I don't off-hand see any reason why there has to be a minimum of one instruction argument. I'd think all the repetitions around
$arguments_tyin both macro cases could use*instead of+. But given that all the current instructions do have at least one argument, obviously that's not a necessary change.
Wasmtime GitHub notifications bot (Aug 24 2022 at 19:35):abrown updated PR #4774 from fuzz-single-inst to main.
Wasmtime GitHub notifications bot (Aug 24 2022 at 19:53):abrown has enabled auto merge for PR #4774.
Wasmtime GitHub notifications bot (Aug 24 2022 at 20:10):abrown merged PR #4774.
Last updated: Oct 23 2024 at 20:03 UTC