Stream: git-wasmtime

Topic: wasmtime / PR #4753 Port `Fcopysign`..`FcvtToSintSat` to ...

Wasmtime GitHub notifications bot (Aug 23 2022 at 15:47):

dheaton-arm edited PR #4753 from isle-fpcvt to main:

Ported the existing implementations of the following opcodes to ISLE on
AArch64:

• Fcopysign

  • Also introduced missing support for fcopysign on vector values, as
    per the docs.

  • This introduces the vector encoding for the SLI machine
    instruction.

• FcvtToUint

• FcvtToSint
• FcvtFromUint
• FcvtFromSint
• FcvtToUintSat
• FcvtToSintSat

Copyright (c) 2022 Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 23 2022 at 18:10):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 23 2022 at 18:10):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 23 2022 at 18:10):

cfallin created PR review comment:

I wonder, would it make more sense to build an abstraction here that doesn't require the explicit invoke-for-side-effect-and-discard pattern, perhaps a helper that takes src, checks if NaN and traps if so, and then returns src? Then we could do something like (final_expression (check_nan_and_trap src) ...) in the body of the let. Likewise for min and max (underflow and overflow checks).

Wasmtime GitHub notifications bot (Aug 23 2022 at 18:10):

cfallin created PR review comment:

Can we add some doc comments here to describe what these new helpers do? E.g. for min_fp_value it's not clear to me exactly what the bool and two u8s mean, even though I can sort of guess what the constructor as a whole might do based on the name. Likewise below, especially fpu_on_ri_sli.

Wasmtime GitHub notifications bot (Aug 24 2022 at 10:47):

dheaton-arm updated PR #4753 from isle-fpcvt to main.

Wasmtime GitHub notifications bot (Aug 24 2022 at 10:54):

dheaton-arm updated PR #4753 from isle-fpcvt to main.

Wasmtime GitHub notifications bot (Aug 24 2022 at 17:37):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 24 2022 at 17:37):

cfallin merged PR #4753.

Last updated: Dec 23 2024 at 13:07 UTC