Stream: git-wasmtime

Topic: wasmtime / PR #4750 Port `vconst` to ISLE (AArch64)

Wasmtime GitHub notifications bot (Aug 22 2022 at 15:31):

dheaton-arm opened PR #4750 from isle-vconst to main:

Ported the existing implementation of vconst to ISLE for AArch64, and
added support for 64-bit vector constants.

Also introduced 64-bit vconst support to the interpreter.

Copyright (c) 2022 Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:08):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:08):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:08):

cfallin created PR review comment:

Can we turn this if-chain into a match (with 16 => ..., 8 => ..., _ => panic!())?

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:08):

cfallin created PR review comment:

Likewise here, a match would be a better fit I think.

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:08):

cfallin created PR review comment:

Here too, a match seems appropriate.

Wasmtime GitHub notifications bot (Aug 23 2022 at 08:55):

dheaton-arm updated PR #4750 from isle-vconst to main.

Wasmtime GitHub notifications bot (Aug 23 2022 at 16:40):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 23 2022 at 16:40):

cfallin merged PR #4750.

Last updated: Oct 23 2024 at 20:03 UTC