Stream: git-wasmtime

Topic: wasmtime / PR #4741 x64: Lower stack_addr, udiv, sdiv, ur...

Wasmtime GitHub notifications bot (Aug 19 2022 at 23:47):

elliottt opened PR #4741 from trevor/x64-stack-addr to main:

This PR is based on #4730 and doesn't need to be reviewed until it merges.

---

Lower stack_addr, udiv, sdiv, urem, and srem in ISLE.

For udiv, sdiv, urem, and srem I opted to move the original lowering into an extern constructor, as the interactions with rax and rdx for the div instruction didn't seem meaningful to implement in ISLE. However, I'm happy to revisit this choice and move more of the embedding into ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:45):

elliottt updated PR #4741 from trevor/x64-stack-addr to main.

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:46):

elliottt edited PR #4741 from trevor/x64-stack-addr to main:

This PR is based on #4730 and doesn't need to be reviewed until it merges.

---

Lower stack_addr, udiv, sdiv, urem, and srem in ISLE.

For udiv, sdiv, urem, and srem I opted to move the original lowering into an extern constructor, as the interactions with rax and rdx for the div instruction didn't seem meaningful to implement in ISLE. However, I'm happy to revisit this choice and move more of the embedding into ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:47):

elliottt edited PR #4741 from trevor/x64-stack-addr to main:

This PR is based on #4730 and doesn't need to be reviewed until it merges.

---

Lower stack_addr, udiv, sdiv, urem, srem, umulhi, and smulhi in ISLE.

For udiv, sdiv, urem, and srem I opted to move the original lowering into an extern constructor, as the interactions with rax and rdx for the div instruction didn't seem meaningful to implement in ISLE. However, I'm happy to revisit this choice and move more of the embedding into ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:48):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:59):

elliottt edited PR #4741 from trevor/x64-stack-addr to main:

Lower stack_addr, udiv, sdiv, urem, srem, umulhi, and smulhi in ISLE.

For udiv, sdiv, urem, and srem I opted to move the original lowering into an extern constructor, as the interactions with rax and rdx for the div instruction didn't seem meaningful to implement in ISLE. However, I'm happy to revisit this choice and move more of the embedding into ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:59):

elliottt updated PR #4741 from trevor/x64-stack-addr to main.

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:03):

elliottt updated PR #4741 from trevor/x64-stack-addr to main.

Wasmtime GitHub notifications bot (Aug 22 2022 at 21:05):

elliottt has marked PR #4741 as ready for review.

Wasmtime GitHub notifications bot (Aug 23 2022 at 00:27):

elliottt updated PR #4741 from trevor/x64-stack-addr to main.

Wasmtime GitHub notifications bot (Aug 23 2022 at 18:22):

elliottt merged PR #4741.

Last updated: Dec 23 2024 at 13:07 UTC