Wasmtime GitHub notifications bot (Aug 19 2022 at 19:59): Wasmtime GitHub notifications bot (Aug 19 2022 at 19:59):elliottt opened PR #4740 from trevor/widen-high-bug to main:
- Add a panic to catch cases where loads are sunk and also used
- Fix multiple uses of the same Value as both Reg and RegMem
- Add a test case for the bug from #4736
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 19 2022 at 20:01):elliottt edited PR #4740 from trevor/widen-high-bug to main:
Fixes #4736
Fix lowerings that were using values as both a
Regand aRegMem, making it look like a load could be sinked in some cases.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 19 2022 at 20:07):elliottt has marked PR #4740 as ready for review.
Wasmtime GitHub notifications bot (Aug 19 2022 at 20:10):elliottt edited PR #4740 from trevor/widen-high-bug to main:
Fixes #4736
Fix lowerings that were using values as both a
Regand aRegMem, making it look like a load could be sinked in some cases. Also add an assert that checks that loads that are sunk are never used.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 19 2022 at 20:47):elliottt requested cfallin for a review on PR #4740.
Wasmtime GitHub notifications bot (Aug 19 2022 at 20:49):elliottt edited PR #4740 from trevor/widen-high-bug to main:
Fixes #4736
Fix lowerings that were using values as both a
Regand aRegMem, making it look like a load could be sunk while its value in a register was still being used. Also add an assert that checks that loads that are sunk are never used.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 19 2022 at 21:13):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 19 2022 at 21:21):elliottt merged PR #4740.
Last updated: Oct 23 2024 at 20:03 UTC