Stream: git-wasmtime

Topic: wasmtime / PR #4740 x64: Fix load sinking bugs in new low...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 19:59):

elliottt opened PR #4740 from trevor/widen-high-bug to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 20:01):

elliottt edited PR #4740 from trevor/widen-high-bug to main:

Fixes #4736

Fix lowerings that were using values as both a Reg and a RegMem, making it look like a load could be sinked in some cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 20:07):

elliottt has marked PR #4740 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 20:10):

elliottt edited PR #4740 from trevor/widen-high-bug to main:

Fixes #4736

Fix lowerings that were using values as both a Reg and a RegMem, making it look like a load could be sinked in some cases. Also add an assert that checks that loads that are sunk are never used.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 20:47):

elliottt requested cfallin for a review on PR #4740.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 20:49):

elliottt edited PR #4740 from trevor/widen-high-bug to main:

Fixes #4736

Fix lowerings that were using values as both a Reg and a RegMem, making it look like a load could be sunk while its value in a register was still being used. Also add an assert that checks that loads that are sunk are never used.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 21:13):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2022 at 21:21):

elliottt merged PR #4740.


Last updated: Dec 23 2024 at 12:05 UTC