Wasmtime GitHub notifications bot (Aug 19 2022 at 18:17): Wasmtime GitHub notifications bot (Aug 19 2022 at 18:17):afonso360 opened PR #4738 from fix-inst-fmt to main:
:wave: Hey,
So in #4733 oss-fuzz discovered that we have pretty much been using the wrong instruction formats for all opcodes for a while... (Thanks @jameysharp for digging into this!).
This PR does 2 things:
- Force fuzzgen to use the correct InstructionFormat for each opcode
- Add an assert to all InstructionFormat inserters to ensure that this does not happen again (even for other users of cranelift).
Fixes #4733
cc: @cfallin
Wasmtime GitHub notifications bot (Aug 19 2022 at 18:39):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Aug 20 2022 at 00:13):afonso360 updated PR #4738 from fix-inst-fmt to main.
Wasmtime GitHub notifications bot (Aug 20 2022 at 00:40):jameysharp has enabled auto merge for PR #4738.
Wasmtime GitHub notifications bot (Aug 20 2022 at 00:49):jameysharp merged PR #4738.
Last updated: Dec 23 2024 at 12:05 UTC