Stream: git-wasmtime

Topic: wasmtime / PR #4730 x64: Lower fcopysign, ceil, floor, ne...

Wasmtime GitHub notifications bot (Aug 17 2022 at 23:38):

elliottt opened PR #4730 from trevor/x64-copysign-ceil-floor-nearest-trunc to main:

This PR is based on #4729 and doesn't need to be reviewed until it merges.

---

Add tests for fcopysign, ceil, floor, nearest, and trunc, and lower all of those instructions in ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 18 2022 at 00:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 18 2022 at 00:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 18 2022 at 00:03):

cfallin created PR review comment:

Here we're implicitly relying on the rule-ordering heuristic again (that pesky #4717!): this rule doesn't do anything to guard on not SSE4.1 and it's not clear to me that the sequence of PatternInsts is "less specific" and shadowed by the above rule without going through the compilation in my head... let's leave this for now though as we are likely to resolve #4717 soon.

Wasmtime GitHub notifications bot (Aug 18 2022 at 20:21):

elliottt updated PR #4730 from trevor/x64-copysign-ceil-floor-nearest-trunc to main.

Wasmtime GitHub notifications bot (Aug 19 2022 at 04:12):

elliottt updated PR #4730 from trevor/x64-copysign-ceil-floor-nearest-trunc to main.

Wasmtime GitHub notifications bot (Aug 19 2022 at 04:12):

elliottt edited PR #4730 from trevor/x64-copysign-ceil-floor-nearest-trunc to main:

Add tests for fcopysign, ceil, floor, nearest, and trunc, and lower all of those instructions in ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 19 2022 at 04:13):

elliottt has marked PR #4730 as ready for review.

Wasmtime GitHub notifications bot (Aug 19 2022 at 04:13):

elliottt requested cfallin for a review on PR #4730.

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 20:57):

elliottt merged PR #4730.

Last updated: Dec 23 2024 at 13:07 UTC