elliottt opened PR #4728 from trevor/sse-cmp-op-bug
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt edited PR #4728 from trevor/sse-cmp-op-bug
to main
:
The rules for
$F32X4
and$F64X2
overlap with the rules for(multi_lane 32 4)
and(multi_lane 64 2)
respectively. Additionally they would return SSE opcodes that must be used withxmm_rm_r_imm
, but the result ofsse_cmp_op
is used directly withxmm_rm_r
in the definition ofvector_all_ones
. If these cases were to suddenly become reachable through a heuristic change in ISLE, we would start seeing panics during code generation for lowerings that rely onvector_of_ones
.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt has marked PR #4728 as ready for review.
elliottt updated PR #4728 from trevor/sse-cmp-op-bug
to main
.
Last updated: Dec 23 2024 at 12:05 UTC