Stream: git-wasmtime

Topic: wasmtime / PR #4727 Limit the size of functions in the `s...

Wasmtime GitHub notifications bot (Aug 16 2022 at 21:21):

alexcrichton opened PR #4727 from faster-stacks-fuzzing to main:

The fuzzers recently found a timeout in this fuzz test case related to
the compile time of the generated module. Inspecting the generated
module showed that it had 100k+ opcodes for one function, so this commit
updates the fuzzer to limit the number of operations per-function to a
smaller amount to avoid timeout limits.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 16 2022 at 21:41):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Aug 16 2022 at 21:41):

jameysharp created PR review comment:

My impression is it would be better to use Unstructured::arbitrary_len, to make the best use of the random input and give the fuzzer better opportunities to manipulate the generated objecs:

            let mut ops = Vec::new();
            for _ in 0..u.arbitrary_len()?.min(MAX_OPS) {
                let mut op = u.arbitrary()?;

(And an ops.push(op); at the end.)

Wasmtime GitHub notifications bot (Aug 17 2022 at 14:26):

alexcrichton updated PR #4727 from faster-stacks-fuzzing to main.

Wasmtime GitHub notifications bot (Aug 17 2022 at 14:26):

alexcrichton created PR review comment:

Sure thing

Wasmtime GitHub notifications bot (Aug 17 2022 at 14:26):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2022 at 15:09):

alexcrichton updated PR #4727 from faster-stacks-fuzzing to main.

Wasmtime GitHub notifications bot (Aug 17 2022 at 15:52):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2022 at 15:53):

alexcrichton has enabled auto merge for PR #4727.

Wasmtime GitHub notifications bot (Aug 17 2022 at 15:56):

alexcrichton merged PR #4727.

Last updated: Dec 23 2024 at 13:07 UTC