Stream: git-wasmtime

Topic: wasmtime / PR #4726 Remove unreachable x64 lowerings for ...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 20:59):

jameysharp requested elliottt for a review on PR #4726.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 20:59):

jameysharp opened PR #4726 from unreachable-lowering to main:

All of the *_imm instructions are rewritten during legalization to an explicit iconst plus the general form of the operator, so backends never see them. Therefore these ISLE rules in the x64 backend can never match anything.

This came up in #4721 but is independent of that issue.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 21:03):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 21:07):

jameysharp has enabled auto merge for PR #4726.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 22:54):

jameysharp merged PR #4726.


Last updated: Dec 23 2024 at 12:05 UTC